-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SkeletonIK3D get
/set_interpolation
compat from #87888
#90780
Conversation
e0ed65d
to
db96888
Compare
db96888
to
f146425
Compare
This should also remove these lines from
We shouldn't need to ignore those messages with the new compatibility methods |
get
/set_interpolation
compat from #87888
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from David's comment, looks good to me.
f146425
to
e1ccbd3
Compare
I tried removing the two lines as @dsnopek asked, but now it's complaining that the APIs I am adding i this PR were removing. Any extension API experts out there able to figure out what I did wrong? |
Those methods (and the property) actually need to be readded as normal methods, not as compat methods. Compat methods are for when we break compat by changing a method prototype. Here, the old method bindings should just be brought back, but the implementation of these methods now defers to the new influence method. Remember to also add the property back, and remove its line from the .expected file. And then in the doc XML, you can mark the property as deprecated. All relevant code should be enclosed in |
e1ccbd3
to
6e89ea9
Compare
6e89ea9
to
816b3e9
Compare
816b3e9
to
d7acadc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now, should pass checks.
d7acadc
to
cb7ef2b
Compare
I used |
Yeah that sounds good to me. |
Thanks! |
Adds both SkeletonIK3D functions mentioned in issue #90303
interpolation was moved to influence, so the compat methods forward to the influence getter/setter.